Conversation
|
My initial impression is that it would be worth keeping consistency between platforms here - if IMHO, ideally, it would have the same external command surface as well - the If there are opportunities to consolidate other arguments or details of the command surface, that would be an added bonus. |
|
I agree that would be a good idea eventually, and I already suggested adding the |
freakboy3742
left a comment
There was a problem hiding this comment.
These changes all look like they make sense; but I'm not sure I'm 100% comfortable merging them without a better picture of what the end state looks like.
I understand there's the pressure to get this into the final 3.13 release; given that has been accelerated to today (+/- timezones), the idea of landing a non-trivial refactor of the Android runner potentially hours before the final release makes me nervous. Whatever the flaws and limitations of the current runner, we know the current state of the Android runner works; if we've missed anything in this refactor, we won't have any opportunity to fix it.
Plus - if the motivation for the backport is that we can't easily update the Android runner for cibuildwheel (et al) purposes, splitting out the runner into a separate repo and including this refactor there seems like the best motivator to drive adoption of that external runner project.
|
Thanks, that makes sense. I wasn't aware that the 3.13 release had been brought forward, but there's no urgency to get this PR into it. As I said in #158018, even if the Python release packages contain an old version of the testbed, cibuildwheel and other external users are still free to get a newer version from somewhere else. |
This is the first step towards splitting the Android testbed into a separate repository. For this PR, all code still remains in the cpython repository, but we create a "lower-level script" as described in the linked issue, which can be used to run Android apps other than the Python testbed.
For example, you can use the script to run one of the test apps from chaquo/chaquopy#1474: