Skip to content

gh-158683: Fix missing source files for _zstd in Modules/Setup - #158672

Open
maxyz wants to merge 1 commit into
python:mainfrom
maxyz:setup_zstd
Open

maxyz wants to merge 1 commit into
python:mainfrom
maxyz:setup_zstd

Conversation

@maxyz

@maxyz maxyz commented Oct 3, 2026 •

Copy link
Copy Markdown

The _zstd module also requires _zstd/zstddict.c, _zstd/compressor.c, and _zstd/decompressor.c.

@python-cla-bot

python-cla-bot Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app

bedevere-app Bot commented Oct 3, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@maxyz

maxyz commented Oct 3, 2026

Copy link
Copy Markdown
Author

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

I consider this change trivial, thus no issue nor added news.

@picnixz

picnixz commented Oct 3, 2026 •

Copy link
Copy Markdown
Member

I consider this change trivial, thus no issue nor added news.

Sorry, but the triviality of a change is at a maintainer's discretion. Have you experienced an issue with the build with the original configuration? if so, please just open an issue with the traceback and what you did so that we can have an historical note. And a NEWS entry is still required since custom builds would now be correct I guess?

@StanFromIreland

Copy link
Copy Markdown
Member

This just changes comments in an example, I don't see a need for a blurb. The list actually used is correct:

@MODULE__ZSTD_TRUE@_zstd _zstd/_zstdmodule.c _zstd/zstddict.c _zstd/compressor.c _zstd/decompressor.c

@picnixz

picnixz commented Oct 3, 2026

Copy link
Copy Markdown
Member

This just changes comments in an example

It's not an example, it's the template that users can use for their local dev I think? or even for local builds and shipping I think?

@picnixz

picnixz commented Oct 3, 2026

Copy link
Copy Markdown
Member

Wait, if it's just an example, I wonder why we have it? why not having it in the docs instead?

@StanFromIreland

Copy link
Copy Markdown
Member

Oh no, sorry. I was a little mistaken, I thought we told people to just use this as an example/template (which we kind of do), but at the same time we do also tell them to use it:

cpython/Modules/Setup

Lines 80 to 83 in 1b015e6

# NOTE: Avoid editing this file directly. Local changes should go into
# Modules/Setup.local file. To enable all modules for testing, run
#
# sed -n -E 's/^#([a-z_\*].*)$/\1/p' Modules/Setup > Modules/Setup.local

I suppose this deserves a news entry then.

@bedevere-app

bedevere-app Bot commented Oct 3, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@maxyz maxyz changed the title Fix missing source files for _zstd in Modules/Setup gh- 158683: Fix missing source files for _zstd in Modules/Setup Oct 3, 2026
@maxyz maxyz changed the title gh- 158683: Fix missing source files for _zstd in Modules/Setup gh-158683: Fix missing source files for _zstd in Modules/Setup Oct 3, 2026
The _zstd module also requires _zstd/zstddict.c, _zstd/compressor.c, and
_zstd/decompressor.c.
@maxyz

maxyz commented Oct 3, 2026

Copy link
Copy Markdown
Author

Thanks for the reviewing, I submitted the issue and added the news. Please take another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants