Conversation
Read insertion order from the iterator's captured values snapshot instead of re-reading ma_values and asserting against a concurrently changing size. Retry under the dictionary lock when a value slot has been cleared. Make insertion-order writes atomic and publish size changes with release stores, pairing with the iterator's size load. Keep order-byte accesses relaxed. Add _Py_atomic_store_uint8_release() and FT_ATOMIC_STORE_UINT8_RELEASE() for this.
nascheme
added
type-bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix crashes and debug-build assertion failures in the free-threaded build when iterating over a split dictionary while another thread deletes entries or clears it. Publish insertion-order updates atomically so readers cannot observe an increased size before the corresponding order entry is initialized.
This is based on the patch attached to GH-158197 with some refinement. Note that AI agents (Claude and GPT) assisted in making and testing change.