gh-158574: Stabilize TLBC cache refresh tests - #158801
Merged
Merged
Conversation
pablogsal
added
needs backport to 3.14
pablogsal
enabled auto-merge (squash)
October 5, 2026 01:02
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
Sorry, @pablogsal, I could not cleanly backport this to Please backport manually with cherry_picker, see the devguide for more information. |
|
GH-158817 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
|
GH-158818 is a backport of this pull request to the 3.14 branch. |
pablogsal
pushed a commit
that referenced
this pull request
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #158574.
The TLBC cache refresh tests can sample a worker while it is returning from
go.wait()and enteringleaf(). Reading the thread state and stack at different times can produce an inconsistent frame snapshot, causing invalid memory reads or incorrect line numbers.Have each worker notify a native SimpleQueue when it reaches its waiting function, then block in a native lock. The sampler waits for those notifications before reading the stacks. Both tests retain the same unwinder across phases and check the expected frames and source lines.