Skip to content

Remove m_remainder() - #158826

Draft
skirpichev wants to merge 1 commit into
python:mainfrom
skirpichev:remove-m_remainder
Draft

skirpichev wants to merge 1 commit into
python:mainfrom
skirpichev:remove-m_remainder

Conversation

@skirpichev

Copy link
Copy Markdown
Member

No description provided.

@skirpichev skirpichev added DO-NOT-MERGE 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Oct 5, 2026
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @skirpichev for commit a18af12 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F158826%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 5, 2026
@picnixz

picnixz commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Can we have an issue about replacing our remainder with C math remainder?

@skirpichev

Copy link
Copy Markdown
Member Author

replacing our remainder with C math remainder?

It looks like it's already completely broken for Window$ (Tier 1) and Android (Tier 3). (In #101679 I did similar attempt for lgamma/tgamma. IIRIC, tests were broken on Win/Mac.)

So, it's not ready yet. Though, maybe it's a good idea to document why we need this implementation, with a list of broken platforms... For m_log*() functions things now might be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants