Repository navigation
Conversation
pablogsal
added
type-feature
pablogsal
force-pushed
the
keyword-typo-token-replay
branch
3 times, most recently
from
October 18, 2026 14:58
a39cdf2 to
05fb3a1
Compare
johnslavik
self-requested a review
October 20, 2026 16:54
Skip immortal interning for replay-only identifiers and dotted names. The parser can then release those strings after each trial.
Separate candidate collection, trial acceptance, and hint construction. Keep trial allocation and cleanup together, and restore the original syntax error through one exit path.
A trial can reject a bytes literal without a pending exception. Stop the decode-error path before it requires that exception, and preserve the original syntax error.
Use a named alias type with constant pointer fields so the alias table is explicitly immutable.
pablogsal
force-pushed
the
keyword-typo-token-replay
branch
from
October 20, 2026 18:30
cadefcb to
2497054
Compare
Member
Author
|
(About half of this diff is generated parser code) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move keyword typo hints into the parser and attach the result to
SyntaxError. Replay private token copies through the grammar, with one replacement per trial. Release trial tokens and identifiers with their arena. Remove source recompilation and statement-location metadata from traceback.Search the complete logical statement and count adjacent letter swaps as one edit. Preserve comma diagnostics and support typos that spell another keyword.
Limit the search to 256 KiB, 32,768 tokens, 32 candidates, and 5 million rule entries across all trials. Keep the normal parser's fast stack check.
Fixes #159672.