Repository navigation
gh-160036: Document tokenize.TokenInfo separately - #160037
Merged
Merged
Conversation
johnslavik
added
docs
johnslavik
changed the title
johnslavik
changed the title
tokenize.TokenInfo separately
Documentation build overview
37 files changed ·
|
Member
Author
|
This ported pre-existing documentation doesn't capture any crucial invariants (1-based rows, 0-based columns, exclusive end positions -- to name a few). I'll expand the docs on this. |
lysnikolaou
reviewed
Oct 21, 2026
lysnikolaou
left a comment
lysnikolaou
left a comment
Member
There was a problem hiding this comment.
thanks @johnslavik! lgtm in general. left some comments.
lysnikolaou
approved these changes
Oct 21, 2026
lysnikolaou
left a comment
lysnikolaou
left a comment
Member
There was a problem hiding this comment.
LGTM! thanks @johnslavik!
lysnikolaou
reviewed
Oct 21, 2026
|
Thanks @johnslavik for the PR, and @lysnikolaou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-160112 is a backport of this pull request to the 3.15 branch. |
|
GH-160113 is a backport of this pull request to the 3.14 branch. |
lysnikolaou
pushed a commit
that referenced
this pull request
Oct 21, 2026
…H-160037) (#160113) (cherry picked from commit 134a19e) Co-authored-by: Bartosz Sławecki <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tokenize.TokenInfo#160036