Repository navigation
Make PathHelper bounds checks explicit - #54
Merged
Merged
Conversation
Use subtraction-based bounds checks in the AVX2, SSE2, and ARM64 paths to avoid relying on input size limits to prevent integer overflow. Add a Debug.Assert before creating the partial-pattern span to explicitly verify that its length is within the source string. This is a defensive refactoring, not a fix for an existing bug or reachable out-of-bounds memory access. Current callers supply strings, and CoreCLR's string length limit already prevents the original addition from overflowing. The change expresses the bounds requirements locally rather than relying on constraints enforced elsewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make bounds checks in
PathHelperexplicit in theAVX2,SSE2, andARM64paths.This is a defensive refactoring, not a fix for an existing bug or reachable out-of-bounds memory access. Current callers supply strings, and CoreCLR's string length limit already prevents the original addition from overflowing.
The updated checks express the bounds requirements locally rather than relying on constraints enforced elsewhere.