Skip to content

parsers: prevent invalid casts in Repeat<Unit> #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rameel merged 1 commit into from
Sep 28, 2026
Merged

parsers: prevent invalid casts in Repeat<Unit> #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Ramstack.Parsing/Parser.Repeat.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ public static Parser<List<T>> Repeat<T>(this Parser<T> parser, int min, int max)
Argument.ThrowIfNegativeOrZero(max);
Argument.ThrowIfGreaterThan(min, max);

return parser is ICharClassSupport s
return typeof(T) == typeof(char) && parser is ICharClassSupport s
? (Parser<List<T>>)(object)CreateRepeatParser(s.GetCharClass(), min, max)
: new RepeatParser<T>(parser, min, max);
}
Expand Down
13 changes: 13 additions & 0 deletions tests/Ramstack.Parsing.Tests/ParsersTests.Repeat.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,19 @@ public void Repeat_5_10_Test()
Assert.That(parser.Parse("aaaa").Success, Is.False);
}

[Test]
public void Repeat_UnitCharParser_ReturnsUnitList()
{
var parser = L('a').Void().Repeat<Unit>(2, 3);
var result = parser.Parse("aaaa");

Assert.That(result.Success, Is.True);
Assert.That(result.Value, Is.EqualTo(new Unit[3]));
Assert.That(result.Length, Is.EqualTo(3));

Assert.That(parser.Parse("a").Success, Is.False);
}

[Test]
[SuppressMessage("ReSharper", "InconsistentNaming")]
public void Repeat_InfiniteLoopPrevention_ZeroLength()
Expand Down
Loading