Repository navigation
parsers: make Return produce an empty matched segment - #40
Merged
Merged
Conversation
Return consumes no input, but it left the matched segment of the
previous parser in the context. Text() and Map then read that stale
text: L("abc").Then(Return(42).Text()) produced "abc" instead of "".
Return now calls Advance(0), as Eof, Optional and DefaultOnFail already
do. The segment is empty and sits at the position where Return was
applied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return consumes no input, but it left the matched segment of the previous parser in the context.
Text()andMapthen read that stale text:L("abc").Then(Return(42).Text())produced"abc"instead of"".Return now calls
Advance(0), asEof,OptionalandDefaultOnFailalready do. The segment is empty and sits at the position whereReturnwas applied.