Restore nested ScrollView manager generation parity - #58779
Closed
Abbondanzo wants to merge 2 commits into
Closed
Abbondanzo wants to merge 2 commits into
Abbondanzo wants to merge 2 commits into
Conversation
Summary: Treat a null dynamic length-percentage value as the expected property-reset case instead of reporting it as an unsupported type. Preserve the existing null result while avoiding a warning whenever a percentage border radius is cleared. Add focused coverage for point, percentage, negative, opt-in negative, and null parsing behavior. Changelog: [Android][Fixed] - Avoid warning when clearing percentage border radii Differential Revision: D122278946
Summary: Regenerate `ReactNestedScrollViewManager` from `ReactScrollViewManager` so the checked-in output exactly matches its generator. This incorporates an existing Kotlin formatting delta and refreshes the SignedSource token. Changelog: [Internal] Differential Revision: D122278947
meta-cla
Bot
added
the
CLA Signed
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D122278947. |
|
This pull request has been merged in 53237c7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Regenerate
ReactNestedScrollViewManagerfromReactScrollViewManagerso the checked-in output exactly matches its generator. This incorporates an existing Kotlin formatting delta and refreshes the SignedSource token.Changelog:
[Internal]
Differential Revision: D122278947