Repository navigation
Spec 001 T022: the authors' names are the graph importer's to fix - #96
Merged
Merged
Conversation
The release's converter wrote each Person's stored _displayName and built no name of its own; only that value tells the 62 people apart, and no rule on the graph's Person fields reproduces the published files. The fix is for the importer to keep a Person's _displayName as it does every other class's: reactome/graph-importer#10, linked from differences.md and noted under T022. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 001, T022 (tickets linked from
differences.md). Documentation only.differences.md, "Authors' names": the open question ("which form is meant") is replaced by the conclusion: the fix is the graph importer's, Keep a Person's stored _displayName instead of rebuilding it graph-importer#10.ReactomeToBioPAXPublicationConverter) wrote each Person's stored_displayNameand built no name of its own.tasks.md, T022: "drafted, not opened" becomes "opened", with the link. T022 stays open for its other tickets.Prettier passes. No names.
🤖 Generated with Claude Code