Repository navigation
Conversation
Intercept the import unit tests' HTTP calls with nock so they go through Node's native fetch instead of a stubbed globalThis.fetch. Co-authored-by: Jon Ursenbach <[email protected]>
Contributor
[Low impact] The PR appears safe to merge; no actionable bugs were established. Reviews (1) · Last reviewed commit: "test: replace global fetch overrides wit..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The import unit tests were stubbing
globalThis.fetchwith hand-rolled responses. Those stubs never exercised Node's nativefetch, so redirect behavior (response.urlafter a hop) was faked by returning a different URL from the mock.This switches those tests to
nock(devDependency).test/mock-fetch.jsregisters one persistent interceptor per origin and still accepts the same route maps the tests already used:Errorfails the requestfinalUrlis a real 302, sofetchfollows it andresponse.urlis the landed URLnpm test(oxlint, oxfmt, and the full Vitest suite) passes.