Repository navigation
Support data-* attributes in DOM JSX - #933
Draft
anmonteiro wants to merge 4 commits into
Draft
anmonteiro wants to merge 4 commits into
anmonteiro wants to merge 4 commits into
Conversation
Member
|
Note on digits: server-reason-react's ppx converts data attribute names differently when a digit follows a letter.
server-reason-react puts a dash before every character that is unchanged by If one component is rendered on the server with server-reason-react and hydrated with reason-react, the attribute names will not match. We should agree on one rule. |
This was referenced Oct 24, 2026
anmonteiro
force-pushed
the
anmonteiro/proposal-data-attrs
branch
from
October 24, 2026 23:14
5d27b57 to
6f1ef6b
Compare
anmonteiro
changed the title
data-* attributes in DOM JSXThis branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support arbitrary string-valued data attributes in DOM JSX, including optional attributes. Builds on #934 and #935, adapting their baseline tests to exercise JSX support. Fixes #230; related to melange-re/melange#2004.
01a17001-efda-7320-8b10-3844e629533f