Repository navigation
Conversation
rfprod
commented
Oct 31, 2026
Owner
- bump version to 0.4.0;
- add rag and skip_embedding parameters to argument functions and CLI;
- implement streaming mode for print() and print_message();
- update loop increment style for consistency;
- replace printf calls with UserInterface and remove emoji from messages;
- rename config to ollama_config for clarity;
- add retrieving_utils with RetrievingUtils class and RetrievingUtilsConfig;
- implement retrieve(), generate_answer(), and run() methods in RetrievingUtils;
- initialize RetrievingUtils in RAG execution path;
- add get_config_value and get_url_value getter methods to clients;
- refactor streaming with callback-based approach for HTTP and LLM;
- add fetch_web_content_stream and curl_streaming_write_callback;
- add WebContentStream struct and process_chunk for JSON buffering and parsing;
- convert WriteCallback to member function curl_write_callback for streaming;
- move process_response to public section of OllamaClient;
- refactor process_response_stream to accept const reference;
- improve variable declaration ordering and extract inline map initialization;
- improve control flow with else-if pattern;
- [x] bump version to 0.4.0; - [x] add rag and skip_embedding parameters to argument functions and CLI; - [x] implement streaming mode for print() and print_message(); - [x] update loop increment style for consistency; - [x] replace printf calls with UserInterface and remove emoji from messages; - [x] rename config to ollama_config for clarity; - [x] add retrieving_utils with RetrievingUtils class and RetrievingUtilsConfig; - [x] implement retrieve(), generate_answer(), and run() methods in RetrievingUtils; - [x] initialize RetrievingUtils in RAG execution path; - [x] add get_config_value and get_url_value getter methods to clients; - [x] refactor streaming with callback-based approach for HTTP and LLM; - [x] add fetch_web_content_stream and curl_streaming_write_callback; - [x] add WebContentStream struct and process_chunk for JSON buffering and parsing; - [x] convert WriteCallback to member function curl_write_callback for streaming; - [x] move process_response to public section of OllamaClient; - [x] refactor process_response_stream to accept const reference; - [x] improve variable declaration ordering and extract inline map initialization; - [x] improve control flow with else-if pattern;
rfprod
enabled auto-merge (squash)
October 31, 2026 20:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.