Repository navigation
States what the case schema's runner compares - #446
Merged
Merged
Conversation
Two description strings in conformance/schema/case.json claimed more than the runner and the schema do. - expect_position said the runner compares every member exactly. It compares each as a JSON value: numbers by value (a float 2.0 agrees with a 2), arrays in order, objects member by member, and anything else exactly, as the conformance README already says. - active_invocations said its items are sorted by state and then by index. The corpus writes them in that order, but the schema does not check it; the description now says so, as history_values' does. Description text only: no keyword changes, and no case's verdict moves. No Elixir code changes, so no gate run applies; no changelog fragment (conformance fixtures). Refs: st-1rdw
johnnyt
force-pushed
the
st-1rdw-case-json-descriptions
branch
from
October 11, 2026 15:46
5c87e83 to
27342f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: st-1rdw
What changes
Two
descriptionstrings inconformance/schema/case.jsonclaimed morethan the runner and the schema do. Description text only: no keyword
changes, so no case validates differently and no case's verdict moves.
expect_positionsaid "the runner compares every member exactly, orderincluded".
PositionExpectation.compare/3compares each member as a JSONvalue (
same?/2): numbers by value, so a float2.0agrees with a2;arrays in order; objects member by member; anything else exactly. The
description now says that, in the words
conformance/README.md's "What astep's position claims" already uses.
active_invocationssaid its items are "sorted by state and then byindex". The corpus writes them in that order
(
PositionExpectation.render/1), but the schema has no keyword thatchecks it. The description now says the corpus writes them sorted and the
schema does not check the order, as
history_values' description does.No changelog fragment (
changelog.d/README.mdexcludes conformancefixtures).
Gate
No Elixir code changes, so under the repo's commit rule no gate run is
required. The merge profile (
mix quality --profile merge), a full run,is green on this commit, the ADR judge skipped because no file is in a
judged scope.
Review
Tier: gate (schema description text). In-turn review checked both claims
against
PositionExpectationand found nothing else to change.conformance/RATCHET.md'sexpect_positionsection makes the same"exactly" claim; it is outside the two strings this change names and is
reported separately.