Repository navigation
Enables the README stage at severity error - #449
Merged
Merged
Conversation
The ex_quality dev dependency moves to ~> 0.16, the release that ships the README stage, and .quality.exs enables that stage at severity :error with the block statifier_oban already carries. The README keeps its shape as an introduction with a map, and a finding now fails the gate. The gate change log carries the entry for both guarded paths. ex_quality 0.16 also adds an opt-in Diataxis stage, which stays off. The manifest classes its skip as a project-level gap, and CLAUDE.md gives the reason beside the list. Only the ex_quality lock line moves; no file under lib/ changes. Refs: st-gvxj
johnnyt
force-pushed
the
st-gvxj-readme-stage-error
branch
from
October 11, 2026 15:50
3b6f701 to
4d7c31b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Enables ex_quality's README stage at severity
:error, which needs theex_quality ~> 0.16dev dependency.mix.exs:{:ex_quality, "~> 0.15", ...}becomes{:ex_quality, "~> 0.16", ...},options unchanged (dev only,
runtime: false).mix.lock: only theex_qualityline moves (0.15.1 to 0.16.0). The resolveralso offered a newer
decimal; that line was kept at its current version, sono other lock line changes.
.quality.exs:readme: [enabled: :auto, severity: :error], with the commentblock statifier_oban's
.quality.exsalready carries.docs/quality-gate-changes.md: the ADR-0011 entry for both guarded paths. ItsApproved-by:line cites the operator's campaign consent of 2026-10-10, whichpre-approves exactly this change (the 2026-09-23 entry is the precedent for
that shape).
No file under
lib/changes, and no fragment:changelog.d/README.mdlistsquality gate changes among the things that get none.
Provenance
.claude/wurk.jsonandCLAUDE.md: ex_quality 0.16 also ships an opt-inDiataxis stage. It stays off here, and its skip line matched neither of the
manifest's skip lists, so the workflow kit read it as a run-level skip and
refused the gate. The manifest now classes it as a project-level gap (the
pattern statifier_oban, opentelemetry_statifier, statifier_datamodel and
statifier-ui already carry), and
CLAUDE.md's skip-classification sectiongives the reason on the same branch, as that section requires. This changes
no stage and skips nothing: the stage was already off.
under a standing consent, 2026-10-10.
Gate
Full
mix qualitygreen on the rebased head (attested bymix gate.verify):the README stage reports every part present, the Gate guard stage passes on the
new entry, and
mix quality --profile merge(the ADR judge) is clean. Skippedstages: Diataxis (project-level, above), Gettext and the ADR judge in the bare
run (both declared not applicable).
Review
Review tier: gate. The manifest declares no pre-request review agents; the
diff was reviewed in-turn. No record under
docs/adr/changes.