Repository navigation
Reads the variants off a drafts shelf too - #716
Merged
Merged
Conversation
The info tests that hold the graph's mark, slot and end values to the how-to-read paragraph and the key read only the two teaching documents, neither of which draws a drafts shelf, so renaming the tray style left them green. They now read a loan with a shelf as well, through one helper the key's lines share, and the kinds test asserts the graphs give exactly the values the variants table names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bead: sb-jc6m
What changes
The info tests that hold the graph's values to the how-to-read paragraph and the key ("names every value the hook puts after a stem" and "names every kind of mark, slot and end the graph gives", in
test/statifier_blocks/map/info_test.exs) read only the two teaching documents. Neither draws a drafts shelf, so thetrayslot style sat in the variants table with no graph giving it, and renaming it left the suite green.Both tests now read their graphs through one helper,
drawn_graphs/0: the two teaching documents and the loan with a drafts shelf the key tests already used (shelf_root/0).key_lines/0reads the same helper, so the shelf document is built in one place. The kinds test now asserts the graphs give exactly the values the variants table names, so a fixture that stops drawing a variant also turns it red.Test-only: no
lib/change, no changelog fragment (test harness, perchangelog.d/README.md).Sabotage
drawerinStatifierBlocks.Map'sstyle/2andslot_options/5and inStatifierBlocks.Map.Info'sslot/5. The info suite stayed green.slot--${} builds a class nothing names) and "names every kind of mark, slot and end the graph gives" failed on its equality assertion. Restored from a copy, byte-equal.drawn_graphs/0. "names every kind of mark, slot and end the graph gives" failed on its equality assertion, thetrayvalue missing. Restored from a copy, byte-equal.Gate
Full
mix qualitygreen on the committed tree: format, compile, doc links, dependencies, ADR cites, docs, credo, dialyzer, and tests with 4,004 of 4,004 passed at 95.4% coverage. Doctor, gettext and sobelow are skipped as not installed.