Repository navigation
Flips the two 2026-10-10 Amendments to accepted - #722
Merged
Merged
Conversation
Flips ADR-0018's Amendment of 2026-10-10 (decision (d)'s description region, for a document the outline cannot describe) and ADR-0017's Amendment of 2026-10-10 (a caption is the whole first sentence, and a group's rules column carries its own caption) from proposed to accepted, each on its own bold Status line, with the date and statifier_blocks 0.43.0 ahead of the original proposed text, which stays as written. 0.43.0 is published on Hex from the v0.43.0 tag at fa7b1d0 by the release run https://github.com/riddler/statifier_blocks/actions/runs/38114607621. One dated foot Note on each record names the version, the run, the SHA every claim was re-verified at (fa7b1d0) and where each claim reads there, anchor first; the sentences that name a status are met in the Note, not edited. Every claim holds at fa7b1d0. The head Status lines are not extended. Zero removed lines besides the two status lines; no file outside docs/adr/; no changelog fragment (records are excluded). mix adr.cites green. Refs: sb-2zar
The ADR-0017 flip Note said one commit, the release, followed the Amendment's merge at f082d40. Three do: two that touch only changelog.d/ fragments and docs/upgrading.md, then the release. None touches a file the Amendment cites. The sentence is corrected in place in the unmerged Note. Refs: sb-2zar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flips two Amendments of 2026-10-10 to accepted, now that statifier_blocks 0.43.0 is published: flipped to accepted on 2026-10-10 after 0.43.0 shipped, by the release run https://github.com/riddler/statifier_blocks/actions/runs/38114607621 from the
v0.43.0tag atfa7b1d0(job "Verify, gate and publish", every step green, "Publish to Hex" included; Hex lists 0.43.0).Refs: sb-2zar
What changes
docs/adr/0018-the-map-reads-the-view-model.md: the Amendment "decision (d)'s description region, for a document the outline cannot describe" has its own bold Status line flipped in place toaccepted (2026-10-10, statifier_blocks 0.43.0); proposed (2026-10-10, bead sb-sx9v), the original text kept. A dated foot Note records the flip.docs/adr/0017-block-types-explain-themselves.md: the Amendment "a caption is the whole first sentence, and a group's rules column carries its own caption" is flipped the same way (bead sb-eidj), with its own dated foot Note.The shape follows the ADR-0019 flip on main (the status word, date and version lead; the proposed text stays). Neither head
Status:line is extended.docs/adr/README.md's index has no row for either Amendment, so it is not touched. Nolib/,test/orassets/change; no changelog fragment (records are excluded).Direction check (every claim verified on main at
fa7b1d0, cites by anchor)ADR-0018 Amendment: every claim holds at
fa7b1d0. Decision (d)'s amended bullet is the one under "The description region is part of the Map's surface".def description_region(lib/statifier_blocks/editor/map_regions.ex) renders the selected or idle description whendefp outlineanswers{:ok, _}. When the outline raises, that function rescues it into:error, the region renders no description, anddata-map-descriptionis nil, so the attribute is left off. The section'sid,aria-live="polite"andaria-labelare unconditional. The "Legend" fact 0.43.0 added is built only on the described path.defp describable?(lib/statifier_blocks/editor.ex) rescues any raise intofalse, and the editor mounts its description wrapper only:if={@describable?}. The map region staysaria-hidden="true". The 0.42.0 changelog quote reads as printed. Both of the Amendment's line cites (taken at2b40578) still read at the lines printed: the commits after it onmap_regions.ex(the key, its Legend title, a hover note) did not move them.ADR-0017 Amendment: every claim holds at
fa7b1d0.def caption(lib/statifier_blocks/map.ex) answersfirst_sentence/1of the explanation for the branch and the two group types andnilotherwise, and its spec is unchanged.defp put_captionputscaption"Rules: watch the steps while they run" andexplanation_lines(the sentence wrapped) on a group's rules column.defp column_linesfeeds the column's size and its ELK padding and minimum size.defp put_bandanddefp band_widthhold a branch band's one-line caption.function drawCaptionLines(assets/js/statifier_blocks_map.js) draws one line each under the caption. Both cited tests exist under their names: the "captions" describe and "the rules column and the branch band carry their captions". The three commits after the Amendment's own merge (f082d40), two that touch onlychangelog.d/fragments anddocs/upgrading.mdand then the release, touch none of the cited files.Removed lines: the two status lines and nothing else (
git diff origin/main -- docs/adr/).mix adr.cites: every record citation resolves and is unmoved. Gate: none run (docs/adr only, per the repo's commit row); CI runs the full gate.