Repository navigation
Documents the upgrade host's patron resubmission - #228
Merged
Merged
Conversation
The private patron!/3 gains a comment saying a resubmission from an email the branch already holds answers the first row as posted, so a different name on it is not kept. The router migration's comment is reflowed to its neighbours' width, with no word changed.
johnnyt
force-pushed
the
se-kqkb-upgrade-host-registration-doc-polish
branch
from
October 11, 2026 09:39
5ff9b40 to
2f1a219
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two comment-only changes in the upgrade host's registration code.
UpgradeHost.Registrations: the privatepatron!/3carries no@doc, so a comment directly above it now says what it does on a resubmission. When the branch already holds the email, it answers the first row as posted; the row is not updated, so a different name on the resubmission is not kept. Placing the sentence in a comment above the private function was decided by the conductor under a standing consent, 2026-10-11.AddStatifierRouter): its leading comment had one line far wider than the rest; the paragraph is reflowed to its neighbours' width.git diff --word-diffshows only the comment markers moving: no word is added, removed or reordered.No code changes. The upgrade host's exact pins are unmoved (statifier 2.12.1, statifier_blocks 0.42.1, statifier_persistence 0.24.1, statifier_router 0.11.2 and the rest of
upgrade_host/mix.exs).Gate
Run on the rebased head, holding the repo's gate lock and a machine slot:
mix quality: green;upgrade_host/, the Upgrade host CI job's commands (mix deps.get --check-locked,mix compile --warnings-as-errors,mix test): green.Review
In-turn review: a diff critic read the diff against the bead and found the comment true to
patron!/3andsubmit/2, and the reflow word-identical. No record text in this PR.