Repository navigation
Upgrade to Go 1.27.4 and golangci-lint 2.15.0 - #59
Merged
Merged
Conversation
Lint CI follows stable Go while golangci-lint stays pinned, allowing the compiler's export format to outgrow the linter's decoder and prevent analysis. Select Go 1.27.4 as the development toolchain and upgrade golangci-lint to 2.15.0. Read the same toolchain declaration in both primary CI jobs so their Go versions stay aligned. Preserve Go 1.26 as the module minimum to match River's supported release range. Add a Go 1.26 compatibility job with `GOTOOLCHAIN=local` so automatic toolchain selection cannot hide incompatibilities with that release. Declare read-only repository access for the CI token instead of relying on inherited token permissions.
bgentry
force-pushed
the
bg/go-1.27-toolchain
branch
from
November 15, 2026 19:52
4c6e547 to
e2aabdf
Compare
bgentry
commented
Nov 15, 2026
Comment on lines
+9
to
+10
| permissions: | ||
| contents: read |
Contributor
Author
There was a problem hiding this comment.
fixing a CodeQL medium complaint with this bit
Contributor
Author
|
@brandur FYI for visibility, noticed CI failed on master on latest dep update merge. This fixes the causes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 apiframe lint CI fails when its floating
stableGo version advances beyond the pinned golangci-lint release. In the failed run, Go 1.27.4 with golangci-lint 2.13.1 reportsexport data version 5 is greater than maximum supported version 4before it can analyze the code.Set the development toolchain to Go 1.27.4 through
toolchain go1.27.4ingo.mod, upgrade golangci-lint to 2.15.0, and have both primary CI jobs read the toolchain fromgo.mod. This aligns their Go versions and prevents the lint job from independently advancing to a newer Go release.Keep
go 1.26.0as the module minimum to preserve River's current and previous Go release support policy. Add a separate compatibility job that runs the suite on the latest Go 1.26 patch withGOTOOLCHAIN=local, ensuring automatic toolchain upgrades cannot hide incompatibilities with the oldest supported Go release.Limit the CI workflow's
GITHUB_TOKENpermissions tocontents: read, covering all three jobs and resolving CodeQL's missing workflow permissions alert.