Repository navigation
Conversation
Bumps [github.com/klauspost/compress](https://github.com/klauspost/compress) from 1.18.4 to 1.18.7. - [Release notes](https://github.com/klauspost/compress/releases) - [Commits](klauspost/compress@v1.18.4...v1.18.7) --- updated-dependencies: - dependency-name: github.com/klauspost/compress dependency-version: 1.18.7 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
|
🤖 @dependabot rebase |
The current telemetry dependencies require Go 1.26, while the workspace still declares Go 1.25.5. Raise the workspace floor so its modules can be loaded together after integrating the current base branch. Remove an obsolete unused-parameter lint suppression that the full lint pass rejects. Preserve the compression security upgrade and the newer telemetry versions already present on the base branch.
bgentry
left a comment
There was a problem hiding this comment.
🤖 Codex review: Approved after dependency security and compatibility review, including the appended workspace repair.
Upgrade
github.com/klauspost/compress: 1.18.4 → 1.18.7.- Reviewed final head:
0a1704d2d8a65627b8cee053e3822cf20a985fb7; integrates current base84b4f48d414e9030b5e1ef083d0d5809be4a4c58append-only.
Security review
- Old/new module zip and go.mod sums match the Go proxy, pinned sums, and checksum database. Canonical tags resolve to c03560f… and 8668e357… respectively. Compared the 52-file published inventory and full 624-line production source/assembly diff.
- Confirms GHSA-259r-337f-4rfw / CVE-2026-63209 (affected through 1.18.6; fixed in 1.18.7): the S2 dictionary repeat index is validated as uint64 before conversion to int. Other changes cover pooled table zeroing, Zstd dictionary/reset handling, amd64 stack-frame sizing, and Etag canonicalization. No new dependency, unexpected hooks, downloader, credential access, or network destination.
- Reused exact artifact/source evidence for base integration's OTEL 1.45 → 1.47 and related dependency identities; reviewed its graph/sum delta. The otelriver 0.11 → 0.12 sum reconciliation matches the pre-existing 0.12 manifest requirement. No same-version checksum rewrite.
Compatibility repairs
- Commit
0a1704d2d8a6integrates master with a merge parent, raises the workspace Go floor from 1.25.5 to 1.26.0 to match current telemetry requirements, and removes only the obsoletenolint:unparamannotation on a test helper. No history rewrite or resolver bypass.
Compatibility verification
make test/race— all five workspace modules pass against isolated PostgreSQL.- CI-pinned golangci-lint 2.11.4 with Go 1.26.8,
run --timeout 5mfor all five modules — 0 issues. The tool release checksum was verified before execution. GOWORK=off go mod verifyandgo mod tidy -diffin datadogriver and otelriver — passed, no metadata changes.- Tracked contents retain the exact validated snapshot digest after committing. CI build/test, lint, both CodeQL analyses, and aggregate CodeQL all pass on the final pushed head.
Residual risk
Expected architecture-specific assembly/unsafe compression behavior remains; consumer tests exercise native darwin/arm64 and Linux CI adds coverage, without a formal equivalence proof. Existing SDK 1.45 remains affected by GHSA-q7gw-24fr-5p69 and is explicitly assigned to the reviewed SDK-alignment repair in #75. This approval covers the compression fix and compatibility changes, not all telemetry exposure.
|
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting |
🤖 The Datadog integration upgrades
github.com/klauspost/compressfrom 1.18.4 to 1.18.7, fixing GHSA-259r-337f-4rfw / CVE-2026-63209. Malformed S2 dictionaries can overflow a repeat index before it is checked; the patched decoder checks the unsigned bound before converting to an integer.Integrate the current base without rewriting the bot branch, raise the workspace Go floor to 1.26 to match the telemetry dependencies already on master, and remove an obsolete lint suppression rejected by the full lint pass. The existing OpenTelemetry SDK advisory remains tracked by #75; this compression update does not claim to fix it.