Repository navigation
docs(streaming): a container's broker_secret overrides STREAMING_BROKER_SECRET - #180
Open
LoneAngelFayt wants to merge 1 commit into
Open
LoneAngelFayt wants to merge 1 commit into
LoneAngelFayt wants to merge 1 commit into
Conversation
…ER_SECRET Companion to rommapp/romm#5259, which reverses the precedence: the per-container broker_secret now wins and the env var is the fallback for containers that set none.
Open
3 of 4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to rommapp/romm#5259, which reverses the broker secret precedence for streaming containers. A container's own
broker_secretinconfig.ymlnow wins, andSTREAMING_BROKER_SECRETis the fallback for containers that set none. Merge this when #5259 ships in a release.The current pages say the opposite, which would send someone debugging a
403 bad broker secretoff changing the env var while the container's value still wins:docs/using/emulator-streaming.md, "Set the shared secret": per-container secrets and the env var can now be mixed.docs/troubleshooting/emulator-streaming.md, "Launch or save errors out": names which secret RomM actually sends.docs/reference/configuration-file.md: thebroker_secretrow and the example's comment.docs/resources/snippets/env-vars.mdalso carries the old wording, but it is generated from romm'senv.templatebyscripts/gen_env_vars.py, and #5259 updatesenv.template, so it picks up the new text on the next regeneration after the pinned romm ref moves.uv run mkdocs build --strictpasses, and Prettier 3.5.2 with the trunk config is clean on all three files.trunk checkcouldn't run its tools locally (the same missing shared library as before), so CI is the lint gate.AI assistance: this PR was written by Claude Code, under my direction and review.