Repository navigation
Conversation
jblomer
force-pushed
the
restrict-rclogon-v2
branch
from
July 8, 2026 13:55
6950a4d to
b8076f5
Compare
Test Results 22 files 22 suites 3d 6h 56m 58s ⏱️ For more details on these failures, see this check. Results for commit d41aa49. ♻️ This comment has been updated with latest results. |
silverweed
reviewed
Jul 9, 2026
jblomer
force-pushed
the
restrict-rclogon-v2
branch
from
July 10, 2026 08:04
b8076f5 to
b02753b
Compare
hageboeck
reviewed
Jul 10, 2026
hageboeck
left a comment
Member
There was a problem hiding this comment.
This change probably warrants some info in the release notes.
Also, if it's too much work/noise to flip the logic, leave it.
jblomer
force-pushed
the
restrict-rclogon-v2
branch
2 times, most recently
from
October 10, 2026 22:45
ef4d149 to
524479e
Compare
dpiparo
approved these changes
Oct 14, 2026
jblomer
force-pushed
the
restrict-rclogon-v2
branch
from
October 14, 2026 13:27
524479e to
d714644
Compare
jblomer
force-pushed
the
restrict-rclogon-v2
branch
2 times, most recently
from
October 14, 2026 21:27
717b645 to
d41aa49
Compare
Add a new option for constructing TEnv that allows to disable the local level. If disabled, configuration cannot be read anymore into the local level, the local level cannot be saved and values cannot be set in the local level. Effectively, the local level is always empty in this mode. By default, new instances of TEnv have the local level _enabled_. Only gEnv has it disabled to prevent environment poisoning. The old behavior can be restored by setting the ROOTENV_USE_LOCAL environment variable to a non-empty string.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new option for constructing TEnv that allows to disable the local
level. If disabled, configuration cannot be read anymore into the local
level, the local level cannot be saved and values cannot be set in the
local level. Effectively, the local level is always empty in this mode.
By default, new instances of TEnv have the local level enabled. Only
gEnv has it disabled to prevent environment poisoning.
The old behavior can be restored by setting the
ROOTENV_USE_LOCALenvironment variable to a non-empty string.
Note: first two commits submitted as separate PR #22783