Repository navigation
[ntuple] initial support for I/O rules on SoA classes - #23311
Conversation
756139b to
24bcb18
Compare
Test Results 24 files 24 suites 3d 23h 5m 48s ⏱️ For more details on these failures, see this check. Results for commit 60be7b4. ♻️ This comment has been updated with latest results. |
hahnjo
left a comment
hahnjo
left a comment
There was a problem hiding this comment.
LGTM with some minor comments, and one general question: do we require users to create rename rules for "compatible" SoA layouts that have the same record field? In principle, I think we could detect this and "do the right thing"
545a884 to
6ce0818
Compare
You're right, we actually don't need the rename rules on the SoA types. Only on the underlying record types. I clarified this in the tests. |
6ce0818 to
60be7b4
Compare
Add a new RRuleField internal base class containing the code dealing with I/O customization rules. This class is initially used by RClassField and will later be reused by RSoAField.
Adds support for rename and whole-object rules. Errors out when rules with targets or sources are found.
... and remove the GetInMemoryClass() virtual method.
4 participants
Adds support for rename and whole-object rules.
Part of #19230