Repository navigation
[clib] full isolation from ROOT - #23356
Draft
ferdymercury wants to merge 1 commit into
Draft
ferdymercury wants to merge 1 commit into
ferdymercury wants to merge 1 commit into
Conversation
ferdymercury
force-pushed
the
bclib2
branch
from
September 14, 2026 08:25
485d2a3 to
2e79b5f
Compare
Test Results 22 files 22 suites 3d 17h 52m 16s ⏱️ For more details on these failures, see this check. Results for commit 43b00b3. ♻️ This comment has been updated with latest results. |
ferdymercury
force-pushed
the
bclib2
branch
from
September 14, 2026 08:27
2e79b5f to
8d7ca43
Compare
ferdymercury
force-pushed
the
bclib2
branch
from
September 14, 2026 09:43
d914062 to
e7fcf2b
Compare
ferdymercury
added
the
skip code analysis
ferdymercury
force-pushed
the
bclib2
branch
6 times, most recently
from
September 14, 2026 12:22
00cb6fb to
f05dd87
Compare
ferdymercury
marked this pull request as ready for review
September 14, 2026 14:48
ferdymercury
requested review from
bellenot,
couet,
dpiparo,
guitargeek,
hageboeck,
jblomer and
pcanal
as code owners
September 14, 2026 14:48
Member
|
The test failure are seemingly unexpected ... |
pcanal
reviewed
Sep 15, 2026
pcanal
left a comment
pcanal
left a comment
Member
There was a problem hiding this comment.
This looks like a fair step forward (last commit only reviewed here)
Collaborator
Author
On Windows there is a missing cmake target definition abou extern dll or so I guess. Maybe bellenot can help On Linux I guess no space left on device |
ferdymercury
marked this pull request as draft
September 18, 2026 06:06
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@hageboeck this is a "variant" of your nice PR #23150
It builds on top of #23040 so only the last commit is relevant.
It follows your strategy and nomenclature (ROOTclib), but besides privatization, it fully isolates Clib from ROOT.
So the same strategy as libAfterImage, it's full standalone and no longer depends on RConfig headers, etc.
Needs first:
#23040
#23344