[CDT] mv to builtins folder

[ferdymercury]

It could be synced with upstream version or turned later on into a full builtin, fyi @ellert

[github-actions]

Test Results

    24 files      24 suites   4d 3h 41m 0s ⏱️
 3 885 tests  3 884 ✅ 0 💤 1 ❌
83 157 runs  83 156 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 4f8919b.

♻️ This comment has been updated with latest results.

[ferdymercury]

CI failures seem unrelated

[dpiparo]

rebased after merging #23465

Maybe I am wrong, but I cannot find the standard rpm nor deb package around. If those are around, and the package is also in brew, then this can indeed become a standard builtin, like zstd, for example

[ferdymercury]

the standard rpm nor deb package around. If those are around, and the package is also in brew, then this can indeed become a standard builtin, like zstd, for example

Yep, I could take care of adding this to Debian and homebrew, probably @ellert might do the same at some point with Fedora.

First however we have to decide if the failures introduced by the latest version, see #23468, are ok for ROOT, meaning it's ok to update the stressgraphics-ref files. (Otherwise the packaging work would be for nothing)

[dpiparo]

First however we have to decide if the failures introduced by the latest version, see #23468, are ok for ROOT, meaning it's ok to update the stressgraphics-ref files. (Otherwise the packaging work would be for nothing)

Absolutely. Step zero is to be sure these changes are OK, and then we can immediately move to the update.

[pcanal]

Is this move affecting the results of test-stressgraphics-cef?

[linev]

Is this move affecting the results of test-stressgraphics-cef?

@pcanal
On which platform it fails? I do not see.
CEF plugin is in gui/cefdisplay/ directory and should not be affected by the PR

[ferdymercury]

On which platform it fails? I do not see.

https://github.com/root-project/root/pull/23465/checks?check_run_id=110023578506

I think it's a unrelated GPU or GL failure on fedora44

Afaict this should only affect stressgraphics-test if we perform an upgrade to upstream (#23468), if we just move it it should be same result.

[linev]

I see such failure for the first time.

Seems to be it is very rare and fully unrelated. In current state fedora44 is fine.

If cef failures starts appear often - I will try to apply same flags like I did for test-stressgraphics-chrome.

[pcanal]

#23465 (checks)
Seems to be it is very rare and fully unrelated. In current state fedora44 is fine.

Indeed at https://github.com/root-project/root/actions/runs/36585234531/job/112196168169?pr=23465 we see a successful build, so it is a transient error. We should keep an eye on it, in particular we should eventually understand whether this is a cosmetic issue or a more fundamental issue.

[pcanal]

LGTM. Thanks.

[ferdymercury]

Could someone restart the Windows job ? The other failures look unrelated. Thks!

[ferdymercury]

@bellenot remaining failure seems unrelated. Thanks

[ferdymercury]

new ubu26 failure seems unrelated

[pcanal]

Indeed the Ubuntu failure is pre-existing.

[dpiparo]

nice. Thanks for merging.