Repository navigation
[ntuple] Enable disconnecting processors from storage - #23625
Merged
enirolf merged 2 commits intoOct 7, 2026
Merged
Conversation
vepadulano
approved these changes
Oct 6, 2026
vepadulano
left a comment
vepadulano
left a comment
Member
There was a problem hiding this comment.
LGTM, one remark and a clarifying question from my side.
enirolf
force-pushed
the
ntuple-proc-chain-open-files
branch
from
October 6, 2026 11:48
77e9134 to
adee311
Compare
jblomer
reviewed
Oct 6, 2026
jblomer
left a comment
jblomer
left a comment
Contributor
There was a problem hiding this comment.
In principle LGTM. Perhaps could come with a unit tests that create, say, 2000 1-entry files and iterates them. Without this optimization, we should hit a 1024 file descriptor limit at least on some Linux platforms.
To avoid keeping files open, especially in chains.
enirolf
force-pushed
the
ntuple-proc-chain-open-files
branch
from
October 6, 2026 13:02
adee311 to
8112e65
Compare
Test Results 24 files 24 suites 3d 21h 48m 49s ⏱️ For more details on these failures, see this check. Results for commit 8112e65. ♻️ This comment has been updated with latest results. |
jblomer
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid keeping files open, especially in chains.
Hopefully fixes the failing Windows builds in #23477, too.