Repository navigation
Conversation
Instead use MakeInteractive(), GetInteractive(), FreeInteractive() wrappers
While EImageFileTypes used for image format, add extra types which may not directly supported by TImage itself
It returns 1 if image really created, 0 in case of failure and -1 when image format not implemented. Return value important to fall-back to alternative storage if desired Deprecate in ROOT7 old SaveImage method which does not have return value
Now one can use return value to clearly indicate if format not supported Or if failure happens when file was saved
Use new TImage formats to provide correct argument
Move functionality to select device, flush device, wait some time and so on to correspondent painters. Only concrete backend takes care of all necessary updates before getting access to pixmap Now one can try to optimize each backend individually - once they works as before.
It is special routine to sync X11 display, therefore implement it directly in TRootCanvas class where real implementation exists. Actually it only needed in virtualX- and GL-based painters Add special 101 mode to request window attributes. Somehow it better sync for X11 display. Used by GL pad painter for workaround issue root-project#22157
Use special 101 update mode when extra window attributes are requested Remove multiple update and flush - which not reliable, only keep on Mac
No need to use canvas implementation, one can directly invoke gVirtualX methods
linev
requested review from
bellenot,
dpiparo,
guitargeek,
hageboeck,
jblomer,
pcanal and
silverweed
as code owners
October 6, 2026 14:22
linev
marked this pull request as draft
October 6, 2026 14:22
Test Results 23 files 23 suites 3d 19h 12m 36s ⏱️ For more details on these failures, see this check. Results for commit 4c1ede7. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Namely method
TPad::Print().It used for batch and online image creation.
In last case pixel buffers extracted and saved into image file.
There are several workarounds required for GL and X11 canvases.
Main idea of PR - move such workarounds to concrete implementation and
avoid in generic
TPad::Print()code some special workaround handlings.Also
TASImage::FromPad()has too many X11 code which need to bemoved to specific X11/GL/Qt6 parts.
Last big step in cleanup code from
gVirtualXWork in progress ...