Skip to content

[skip-ci][rfile] Add RFile python doc - #23633

Merged
silverweed merged 1 commit into
root-project:masterfrom
silverweed:rfile_doc_py
Oct 23, 2026
Merged

silverweed merged 1 commit into
root-project:masterfrom
silverweed:rfile_doc_py

Conversation

@silverweed

@silverweed silverweed commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #22541

@vepadulano vepadulano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! A few comments from my side.

Comment thread bindings/pyroot/pythonizations/python/ROOT/_pythonization/_rfile.py Outdated
Comment thread bindings/pyroot/pythonizations/python/ROOT/_pythonization/_rfile.py Outdated
Comment thread bindings/pyroot/pythonizations/python/ROOT/_pythonization/_rfile.py Outdated
Comment thread bindings/pyroot/pythonizations/python/ROOT/_pythonization/_rfile.py
Comment thread bindings/pyroot/pythonizations/python/ROOT/_pythonization/_rfile.py
Comment thread bindings/pyroot/pythonizations/python/ROOT/_pythonization/_rfile.py Outdated
Comment thread bindings/pyroot/pythonizations/python/ROOT/_pythonization/_rfile.py Outdated

@jblomer jblomer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principal looks good to me. Should we mention Tree/RNTuple with RFile in this doc?

@silverweed

Copy link
Copy Markdown
Contributor Author

Should we mention Tree/RNTuple with RFile in this doc?

Yes, but for RNTuple we should probably wait that at least RNTupleWriter_Append is moved out of experimental so that it becomes a proper overload of RNTupleWriter::Append (happening here).

For TTree we can mention that it may be read but not written.

For both we probably want to redirect to the respective tutorials, which is why I'd wait this PR to be merged before doing so.

@vepadulano vepadulano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this was definitely important to address!

Comment thread bindings/pyroot/pythonizations/python/ROOT/_pythonization/_rfile.py
@silverweed
silverweed merged commit f529d96 into root-project:master Oct 23, 2026
14 checks passed
@silverweed
silverweed deleted the rfile_doc_py branch October 23, 2026 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[rfile] Add python documentation

3 participants