Repository navigation
Conversation
Since the page source classes are internal, we don't need to stay prepared for a future page source implementing its own parallel unzipping logic. For now, we can make this funtionality just part of the base class.
Avoid taking the page pool lock for every page preload within the TBB tasks but instead push all the pages with a single lock at the end. Brings ~30% speedup for IMT decompression of many small pages.
For the TBB supported parallel decompression, skip creating tasks for pages <4kB. This is the order of magnitude as of which page unsealing is in the 1-10 microseconds regime, where spawning a TBB task starts making sense. Gives another 30% speedup for parallel decompression of small pages.
jblomer
changed the title
Test Results 24 files 24 suites 4d 1h 10m 6s ⏱️ For more details on these failures, see this check. Results for commit e3caad32. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discovered by CMS, the IMT decompression of many small pages creates undersized TBB tasks. This PR more than doubles the IMT read speed with many small pages, while having no effect on the RNTuple standard benchmarks.
Degenerated "many small pages" cases are still faster in single-threaded mode than with IMT, so we may need to revisit that part in the future.