Repository navigation
[core] Add essential unit tests for TObjArray - #23680
Open
ravindra-RKB wants to merge 3 commits into
Open
ravindra-RKB wants to merge 3 commits into
ravindra-RKB wants to merge 3 commits into
Conversation
ravindra-RKB
requested review from
bellenot,
dpiparo and
pcanal
as code owners
October 10, 2026 17:33
pcanal
reviewed
Oct 11, 2026
pcanal
reviewed
Oct 11, 2026
Contributor
Author
|
Thanks for the review @pcanal! I've updated the tests with:
|
Test Results 24 files 24 suites 4d 6h 32m 12s ⏱️ For more details on these failures, see this check. Results for commit f71dd8c. |
Contributor
Author
|
Hi @pcanal, just a gentle ping on this. The requested test enhancements have been added and all TObjArray unit tests are passing cleanly across platforms. Whenever you have a moment, please let me know if anything else is needed or if this is ready to merge. |
Member
|
Closing and Reopening to rebase the CI tests |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces essential unit tests for the
TObjArraycollection class to thecore/contmodule. It verifies common operations like appending, inserting, removing, and iterating over objects within the array, ensuring long-term stability and correctness for this fundamental container against the ROOT test framework.Checklist