Repository navigation
[ntuple] Add slow merging strategy - #23739
Open
silverweed wants to merge 5 commits into
Open
silverweed wants to merge 5 commits into
silverweed wants to merge 5 commits into
Conversation
Test Results 23 files 23 suites 3d 21h 25m 59s ⏱️ For more details on these failures, see this check. Results for commit 9e93a3c. ♻️ This comment has been updated with latest results. |
silverweed
force-pushed
the
ntuple_merge_slow_4_2
branch
3 times, most recently
from
October 20, 2026 14:21
4060719 to
9e93a3c
Compare
Otherwise it'll gonna reuse the already-initialized source, which works but it doesn't test the intended code path
For future use by the Merger
silverweed
force-pushed
the
ntuple_merge_slow_4_2
branch
2 times, most recently
from
October 23, 2026 08:40
a1f9236 to
028c7c6
Compare
silverweed
marked this pull request as ready for review
October 23, 2026 08:44
silverweed
force-pushed
the
ntuple_merge_slow_4_2
branch
from
October 23, 2026 11:33
028c7c6 to
75e930a
Compare
jblomer
approved these changes
Oct 23, 2026
silverweed
force-pushed
the
ntuple_merge_slow_4_2
branch
from
October 23, 2026 12:58
75e930a to
486f2e0
Compare
silverweed
force-pushed
the
ntuple_merge_slow_4_2
branch
from
October 23, 2026 14:59
486f2e0 to
8cfc0e7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds preliminary support for L4 ("slow") merging in the RNTupleMerger.
It does so by adding a new MergeStrategy that implements the slow merging flow. This is not yet enabled in any case by this PR but it will be used by attribute merging in a later PR.
I tested as much as I could this new flow and it works for most cases (the test failures that one would have by setting
doSlowMerge = trueare almost entirely due to test expectations that don't hold for slow merging).Proper testing will be added when slow merging is enabled in the future, but for 6.42 it'll only be used by attributes, and they will get proper tests.