Repository navigation
[ntuple] Properly set bit width/value range when generating column elements from on disk info - #23755
Open
silverweed wants to merge 4 commits into
Open
silverweed wants to merge 4 commits into
silverweed wants to merge 4 commits into
Conversation
1 of 2 tasks
Test Results 24 files 24 suites 4d 7h 42m 20s ⏱️ Results for commit cf69920. ♻️ This comment has been updated with latest results. |
jblomer
approved these changes
Oct 19, 2026
The column type alone is insufficient to create a proper ColumnElement when the element type is one that carries additional info, such as Real32Trunc/Quant. When creating such types one must also set the BitsOnStorage and ValueRange appropriately. To prevent mistakes due to callers forgetting to do so, we force them to pass the complete column descriptor when generating a column element using the <void> overload.
Apply the source column's stored bit width before computing packed page sizes during recompression. This allows truncated and quantized float pages to be merged with a different output compression. Compare both fields against their stored source values in a regression. Assisted-by: codex:gpt-6.1-sol Assisted-by: claude-code:opus
silverweed
force-pushed
the
rcolelembase_generate
branch
from
October 20, 2026 12:30
2f77729 to
cf69920
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
changes the signature of
RColumnElementBase::Generate<void>to pass the entire column descriptor (rather than just the column type) so that the function can properly set the extra column information for types that need it (Real32Trunc/Quant).Also adds an overload for
GenerateColumnElementthat does the same.This fixes a bug in the Merger (reported in #23752, which this PR builds upon/includes) and hopefully prevents similar bugs to appear in the future.
The merger test provided by @Elvand-Lie is included in this PR.
Checklist: