Repository navigation
[ntuple] Throw informative error when collection proxy dictionary is missing (#21274) - #23766
Open
ishaaaan17 wants to merge 1 commit into
Open
ishaaaan17 wants to merge 1 commit into
ishaaaan17 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary of changes
fixes #21274.
when an RNTuple collection proxy field (for example
std::setorstd::map) was created for a type that has no dictionary, ROOT hit an assertion failure inTGenCollectionProxy.cxx:401(R__ASSERT(e->IsValid())), or failed while inspecting the collection proxy.this change:
classp->HasDictionary()in the constructor ofRProxiedCollectionField, before the collection proxy is generated, and throws aROOT::RExceptionwith the name of the missing type ("<type> has no dictionary entry available").tree/ntuple/test/ntuple_types.cxxunderTEST(RNTuple, TVirtualCollectionProxy). it checks that a collection type without a loaded dictionary (std::map<double, double>) throws aROOT::RExceptionwith this error message.checklist
.clang-formatai disclosure
Assisted-by: antigravity:gemini. i used an ai assistant to follow the collection proxy generation call stack in
RProxiedCollectionFieldandTGenCollectionProxy. i checked the dictionary lookup againstTClass::HasDictionary(), wrote the unit test and the exception check, and checked the formatting with.clang-format.