Repository navigation
Avoid out of bound access in TPad - #23768
Merged
vepadulano merged 1 commit intoOct 21, 2026
Merged
Conversation
vepadulano
requested review from
bellenot,
guitargeek,
hageboeck,
linev and
silverweed
as code owners
October 20, 2026 12:14
1 task
vepadulano
force-pushed
the
tpad-fix-out-of-bound-access
branch
from
October 20, 2026 12:16
f330c85 to
e4b7272
Compare
linev
reviewed
Oct 20, 2026
TPad was allowing to access a vector data member that stores the empty cells of the canvas where the legend can be printed. Clamp the NotFree macro to accessing at most the last element of said vector. Add a test.
vepadulano
force-pushed
the
tpad-fix-out-of-bound-access
branch
from
October 20, 2026 14:17
e4b7272 to
6da37a6
Compare
linev
approved these changes
Oct 20, 2026
Test Results 23 files 23 suites 4d 2h 6m 42s ⏱️ Results for commit 6da37a6. |
ferdymercury
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TPad was allowing to access a vector data member that stores the empty cells of the canvas where the legend can be printed. Clamp the NotFree macro to accessing at most the last element of said vector.
Add a test.