Repository navigation
[6.40] [asimage] fix bug in rainbow palette selection - #23771
Open
root-project-bot wants to merge 3 commits into
Open
root-project-bot wants to merge 3 commits into
root-project-bot wants to merge 3 commits into
Conversation
Target array has only 12 elements, but rainbow palette has only 10 points These 10 points should be copied from offset 1, first and last point will be overwritten (cherry picked from commit acc3077)
Use it in assign methods Co-authored-by: ferdymercury <[email protected]> (cherry picked from commit d30dd71)
New kNRainbowElems constant specify number of elements in array, palette should reserve 2 more points (cherry picked from commit 4011503)
Test Results 23 files 23 suites 3d 13h 14m 22s ⏱️ Results for commit 5f675b7. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #23725, requested by @linev.