Prevent crashes with non-Proc as_json callbacks - #1083
Merged
Merged
Conversation
Convert non-Proc callbacks through to_proc and validate the result in both configuration and the as_json setter. rb_convert_type accepts unrelated T_DATA objects without conversion, allowing them to reach Proc APIs and crash. Cover Method callbacks, invalid callback types, and to_proc returning a non-Proc object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing a Method as
as_json, such asas_json: method(:serialize), can segfault in the C extension:rb_convert_type(..., T_DATA, "Proc", "to_proc")accepts any T_DATA object without callingto_proc. Method and other unrelated objects can therefore reachrb_proc_arityorrb_proc_call_with_blockas though they were Procs.Convert non-Proc callbacks through
to_procand validate the result in both option configuration andState#as_json=. Method callbacks are now converted correctly, while unsupported values and non-Proc conversion results raise TypeError.The reproduction above now raises a normal ArgumentError because
+accepts one argument and the callback receives two.