Repository navigation
Raise the Format job timeout to 90 minutes - #24
Merged
Merged
Conversation
The locked workspace test suite was still running when GitHub cancelled rust-check-lint-test at the 45-minute budget. Co-authored-by: RustFS <[email protected]>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the CI job timeout increase.
No open issues 🎉
What changed in this PR
Extends the locked-toolchain CI job’s time budget so workspace tests can run beyond the previous 45-minute cutoff. This changes the CI budget, not test behavior or pass status.
Changes:
- Raises
rust-check-lint-testfrom 45 to 90 minutes. - Adds a comment explaining the previous timeout cancellations.
- Leaves Package and release timeouts unchanged.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Increases the Format, Clippy & Test job timeout and documents why. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Raise only the
rust-check-lint-testjob ("Format, Clippy & Test (locked toolchain)") timeout in.github/workflows/ci.ymlfrom 45 minutes to 90 minutes, so the locked workspace test suite can finish instead of being cancelled at the job budget.The Package job timeout stays at 45 minutes. The release job timeout is unchanged. No product code, test code, or other workflows are modified.
Merging this PR is a CI-budget fix. It is not a first-ship pass, and it is not a claim that the test suite is already green.
Evidence
Independently observed on 2026-11-19 (Asia/Shanghai):
8b93a3899377e3aaf9f2c874b5dd84d8f382a15a, the Format job started at 11:41 and was cancelled at 12:26 (about 45 minutes). rustfmt and clippy had already succeeded on sibling PR runs. The step still running when the job died was "Run full workspace test suite" (cargo test --workspace --locked --no-fail-fast). Package x86_64 and aarch64 both succeeded in about 3 minutes.9304b6f2(Expire proposal receipts and cover concurrent membership #18),3b206b1e(Close backup publish, manifest, and scratch leftovers #19), and880a657a(Add fail-closed auth regressions and a CI-scale prefix load #21): Format was cancelled at 20:23–20:25 after about 45 minutes, while Package succeeded. The workflow conclusion wascancelled, notsuccess.ci.ymlon that main tip setstimeout-minutes: 45onrust-check-lint-test. Concurrency is already scoped per ref (ci-${{ github.workflow }}-${{ github.ref }}); this is not a cross-PR cancel.Test plan
rust-check-lint-testtimeout from 45 to 90 minutes (plus a one-line comment inci.yml).