Skip to content

Raise the Format job timeout to 90 minutes - #24

Merged
loverustfs merged 1 commit into
mainfrom
cursor/ci-format-job-timeout-90-b63f
Nov 19, 2026
Merged

loverustfs merged 1 commit into
mainfrom
cursor/ci-format-job-timeout-90-b63f

Conversation

@loverustfs

Copy link
Copy Markdown
Contributor

Summary

Raise only the rust-check-lint-test job ("Format, Clippy & Test (locked toolchain)") timeout in .github/workflows/ci.yml from 45 minutes to 90 minutes, so the locked workspace test suite can finish instead of being cancelled at the job budget.

The Package job timeout stays at 45 minutes. The release job timeout is unchanged. No product code, test code, or other workflows are modified.

Merging this PR is a CI-budget fix. It is not a first-ship pass, and it is not a claim that the test suite is already green.

Evidence

Independently observed on 2026-11-19 (Asia/Shanghai):

  • On main tip 8b93a3899377e3aaf9f2c874b5dd84d8f382a15a, the Format job started at 11:41 and was cancelled at 12:26 (about 45 minutes). rustfmt and clippy had already succeeded on sibling PR runs. The step still running when the job died was "Run full workspace test suite" (cargo test --workspace --locked --no-fail-fast). Package x86_64 and aarch64 both succeeded in about 3 minutes.
  • The same pattern hit PR heads 9304b6f2 (Expire proposal receipts and cover concurrent membership #18), 3b206b1e (Close backup publish, manifest, and scratch leftovers #19), and 880a657a (Add fail-closed auth regressions and a CI-scale prefix load #21): Format was cancelled at 20:23–20:25 after about 45 minutes, while Package succeeded. The workflow conclusion was cancelled, not success.
  • ci.yml on that main tip sets timeout-minutes: 45 on rust-check-lint-test. Concurrency is already scoped per ref (ci-${{ github.workflow }}-${{ github.ref }}); this is not a cross-PR cancel.

Test plan

  • Confirm the diff changes only the Format / rust-check-lint-test timeout from 45 to 90 minutes (plus a one-line comment in ci.yml).
  • Confirm the Package job remains at 45 minutes and the release job timeout is unchanged.
  • After merge, required CI can run the workspace test suite past the previous 45-minute cancel. This change does not assert that the suite will pass.
Open in Web Open in Cursor 

The locked workspace test suite was still running when GitHub cancelled rust-check-lint-test at the 45-minute budget.

Co-authored-by: RustFS <[email protected]>
Copilot AI balanced review requested due to automatic review settings November 19, 2026 12:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the CI job timeout increase.

No open issues 🎉

What changed in this PR

Extends the locked-toolchain CI job’s time budget so workspace tests can run beyond the previous 45-minute cutoff. This changes the CI budget, not test behavior or pass status.

Changes:

  • Raises rust-check-lint-test from 45 to 90 minutes.
  • Adds a comment explaining the previous timeout cancellations.
  • Leaves Package and release timeouts unchanged.
File Description
.github/​workflows/​ci.yml Increases the Format, Clippy & Test job timeout and documents why.

Review effort: Balanced

@loverustfs
loverustfs merged commit 7ce47a5 into main Nov 19, 2026
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants