Skip to content

fix(scanner): validate carried cold values and endpoint inventories - #154

Merged
cxymds merged 1 commit into
mainfrom
cxymds/fix-usage-public-oracles
Nov 14, 2026
Merged

cxymds merged 1 commit into
mainfrom
cxymds/fix-usage-public-oracles

Conversation

@cxymds

@cxymds cxymds commented Nov 14, 2026

Copy link
Copy Markdown
Member

USAGE-05 timed out when cold buckets exposed exact, complete carried values with their original certificates during hot-bucket writes. Accept certified or carried values only with a valid, stable bucket incarnation, an explicit certificate, exact independently listed counts and bytes, and no pending, partial, observational, or synthetic Admin state. Keep native budget, physical-source, and ACK assertions separate.

The multi-endpoint oracle previously sent all paginated LIST requests to endpoint 0 while GET requests used the selected endpoint. Propagate the selected endpoint through every normal/versioned listing page and record its identity in oracle evidence.

Validation: python3 -m unittest test_validation_scanner_usage (47 passed), Python compilation, and git diff --check. Regressions reject missing certificates, nil or changing incarnations, wrong counts/bytes, incomplete states, and divergent endpoint inventories; pagination tests verify both continuation tokens and version markers on every endpoint. These are runner tests using explicit doubles; candidate VM verification will follow the RustFS #9397 update.

Copilot AI balanced review requested due to automatic review settings November 14, 2026 00:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the scanner-usage validation changes.

No open issues 🎉

What changed in this PR

This PR updates the scanner-usage validation runner to accept valid carried cold-bucket values and verify inventories against the selected endpoint.

Changes:

  • Validate cold values using certificates, stable non-nil bucket incarnations, exact counts and bytes, and complete, non-synthetic Admin state.
  • Route every inventory page through the selected endpoint and record its identity in oracle evidence.
  • Add regressions for invalid cold values, endpoint inventory divergence, and normal/versioned pagination.
File Description
test_validation_scanner_usage.py Adds cold-value validation and endpoint-aware inventory regression tests.
scripts/​validation_scanner_usage/​runner.py Validates carried cold values and propagates endpoint selection through inventory requests.
scripts/​validation_scanner_usage/​client.py Exposes the Admin projection flag in normalized bucket views.

Review effort: Balanced

@cxymds
cxymds merged commit 642fb31 into main Nov 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants