Repository navigation
fix(scanner): validate carried cold values and endpoint inventories - #154
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the scanner-usage validation changes.
No open issues 🎉
What changed in this PR
This PR updates the scanner-usage validation runner to accept valid carried cold-bucket values and verify inventories against the selected endpoint.
Changes:
- Validate cold values using certificates, stable non-nil bucket incarnations, exact counts and bytes, and complete, non-synthetic Admin state.
- Route every inventory page through the selected endpoint and record its identity in oracle evidence.
- Add regressions for invalid cold values, endpoint inventory divergence, and normal/versioned pagination.
| File | Description |
|---|---|
test_validation_scanner_usage.py |
Adds cold-value validation and endpoint-aware inventory regression tests. |
scripts/validation_scanner_usage/runner.py |
Validates carried cold values and propagates endpoint selection through inventory requests. |
scripts/validation_scanner_usage/client.py |
Exposes the Admin projection flag in normalized bucket views. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
USAGE-05 timed out when cold buckets exposed exact, complete
carriedvalues with their original certificates during hot-bucket writes. Accept certified or carried values only with a valid, stable bucket incarnation, an explicit certificate, exact independently listed counts and bytes, and no pending, partial, observational, or synthetic Admin state. Keep native budget, physical-source, and ACK assertions separate.The multi-endpoint oracle previously sent all paginated LIST requests to endpoint 0 while GET requests used the selected endpoint. Propagate the selected endpoint through every normal/versioned listing page and record its identity in oracle evidence.
Validation:
python3 -m unittest test_validation_scanner_usage(47 passed), Python compilation, andgit diff --check. Regressions reject missing certificates, nil or changing incarnations, wrong counts/bytes, incomplete states, and divergent endpoint inventories; pagination tests verify both continuation tokens and version markers on every endpoint. These are runner tests using explicit doubles; candidate VM verification will follow the RustFS #9397 update.