Repository navigation
feat(tenant): support configurable readiness probe timing - #296
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
GatewayJ
force-pushed
the
feat/tenant-readiness-probe
branch
from
November 12, 2026 02:20
ac74d35 to
28de289
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
Refs #295
Summary of Changes
Operator-generated readiness probes currently inherit Kubernetes' one-second timeout, and Tenant configuration cannot adjust it. Add optional
spec.readinessProbetiming settings so the reported five-second workaround can be maintained through normal reconciliation.initialDelaySeconds,timeoutSeconds,periodSeconds,failureThreshold, andsuccessThreshold, with defaults0/5/10/3/1and Kubernetes-compatible minimum values. The Operator continues to select the readiness handler according to Tenant TLS, including mTLS exec and TCP probes.Checklist
make pre-commit(fmt-check + clippy + test + console-lint + console-fmt-check)[Unreleased](if user-visible change)Impact
The API addition is optional. Install the updated Tenant CRD explicitly before upgrading or using the new settings; Helm does not upgrade CRDs from the chart's
crds/directory. Tenants withoutspec.serviceAccountNameuse enforcedRollingUpdatewith partition zero for default ServiceAccount token protection. Tenants with a custom ServiceAccount retain their existing update strategy and partition. Plan upgrades around available cluster quorum. Setspec.readinessProbe.timeoutSeconds: 1to retain or restore the previous timeout.Verification
5 -> Tenant 5 -> Tenant 8 -> default 5, shared ownership, external HTTP fields, custom-ServiceAccount update strategy preservation, unrelated image conflicts without partial changes, and concurrent updates or same-name replacement between the rejected ordinary apply and force retry.ParallelandOrderedReady, changing probe response delay and timeout together under external timing ownership. Watch events verify complete templates, and all replacement Pods must reach Ready at the final revision. CONTRIBUTING.md documents the context, image, and commands.Additional Notes
This addresses the Operator configuration and reconciliation gap described in #295. The reporter's Nginx HTTP 404 cause and end-to-end read/write availability during the original RKE2/Longhorn node reboot remain unverified. A five-second kubelet probe timeout does not bound all server-side readiness work. The existing mTLS exec command also retains its separate two-second curl timeout. The issue remains open for that investigation.
CI results are pending for the updated commit.