Skip to content

Rollback external strategy protocol for a simpler TCP/JSON implementation - #709

Merged
rustyeddy merged 1 commit into
mainfrom
rollback/strategy-protocol-simplification
Nov 20, 2026
Merged

rustyeddy merged 1 commit into
mainfrom
rollback/strategy-protocol-simplification

Conversation

@rustyeddy

Copy link
Copy Markdown
Owner

Why

The Strategy Protocol milestone accumulated a custom strict JSON codec, separate strategy order model, and a substantial server/session framework before the first end-to-end strategy backtest. Reset the transport layer so we can build → test → decide with existing domain types.

Scope

Next increment (separate PR)

Use a loopback TCP socket with length-prefixed standard encoding/json, reuse existing marketdata.Bar and existing order models, start with one OnBars exchange driving an actual EMAX backtest through the existing engine. No registry, custom codec or subprocess management initially.

Verification

  • git diff --check passed; generated GitHub tree SHA matched the local rollback tree.
  • Go tests could not be executed in this environment (/usr/bin/go is not the Go toolchain); CI should run make check before merge.

This is a reviewable rollback PR, not a force reset of main. No merge requested yet.

Reverts PRs #697, #706, #707 and #708 while preserving PR #696 engine stop amendments and ADR-093. Document historical external strategy ADR scope.
Copilot AI balanced review requested due to automatic review settings November 20, 2026 13:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@rustyeddy
rustyeddy merged commit a4c6653 into main Nov 20, 2026
2 checks passed
@rustyeddy
rustyeddy deleted the rollback/strategy-protocol-simplification branch November 20, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants