Repository navigation
Rollback external strategy protocol for a simpler TCP/JSON implementation - #709
Merged
Merged
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Strategy Protocol milestone accumulated a custom strict JSON codec, separate strategy order model, and a substantial server/session framework before the first end-to-end strategy backtest. Reset the transport layer so we can build → test → decide with existing domain types.
Scope
strategy/proto,strategy/server, public strategy transport types, andtrader serveintegration).trader servebehavior and its tests/docs.Next increment (separate PR)
Use a loopback TCP socket with length-prefixed standard
encoding/json, reuse existingmarketdata.Barand existing order models, start with oneOnBarsexchange driving an actual EMAX backtest through the existing engine. No registry, custom codec or subprocess management initially.Verification
git diff --checkpassed; generated GitHub tree SHA matched the local rollback tree./usr/bin/gois not the Go toolchain); CI should runmake checkbefore merge.This is a reviewable rollback PR, not a force reset of
main. No merge requested yet.