Repository navigation
fix(s4hc): canonical ACCORDION step format so steps parse - #24260
Merged
jung-thomas merged 1 commit intoOct 23, 2026
Merged
Conversation
Contributor
Content (6)
Checked 7fccf70 • notify-only, does not block merge |
jung-thomas
deleted the
fix/s4hc-abap-create-custom-api-accordion-format
branch
October 23, 2026 13:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The tutorial
s4hc-abap-environment-create-custom-apirenders as BROKEN (0 steps, 404 on the live site) even though it has 7 real steps.Root cause
The 7
[ACCORDION-BEGIN]lines use the non-canonical format[Step N: Title](Title)(title inside the bracket). The v1 parser regex expects the canonical[Step N: ](Title)form (empty before]), so it matches 0 steps and the tutorial is quarantined withInvalid stepCount value: 0. Of ~319 accordion lines across the corpus, only these 7 use the broken variant.Fix
Reformat all 7 step headings to canonical
[Step N: ](Title). Verified to parse to 7 steps. No content changed — only the title position in the heading.One half of a mirrored pair (sap-tutorials/Tutorials ⇄ Tutorials-Contribution).
Mirror PR: https://github.com/sap-tutorials/Tutorials-Contribution/pull/42183