Repository navigation
✨ Support dict(entry) by adding Entry.keys() and __iter__ - #631
Merged
Merged
Conversation
Entry mimicked dicts via items(), __getitem__ etc., but lacked keys() and
__iter__, so dict(entry) and list(entry) raised KeyError: 0 and {**entry}
raised TypeError. Both return the keys in items() order.
Refs #629
MiWeiss
added a commit
that referenced
this pull request
Oct 2, 2026
Relies on Entry.keys()/__iter__ from #631.
This was referenced Oct 2, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entrymimics a dict (items(),__getitem__,__contains__, ...) but has nokeys()or__iter__, so the obvious conversions fail:Fix: add
Entry.keys()andEntry.__iter__, both derived fromitems()(ENTRYTYPE,ID, then field keys), sodict(entry) == dict(entry.items()). Entry still isn't aMapping/Collection(no__len__), so the middleware's collection check is unaffected.Tests: one new test in
tests/test_model.py; full suite 2778 passed, 12 skipped. Pre-commit clean.Refs #629