Conversation
Where a field key is expected, `%` up to the end of the line is now parsed as a comment (as in biber; BibTeX does not allow `%` in field keys). Previously, such lines became bogus field keys, were merged into the next field's key, or made the entry fail to parse. Comments are kept: `Field.comments` holds those before a field, `Entry.trailing_comments` those after the last field, and the writer writes them back. Within values and entry keys, `%` stays literal. Closes #372
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Biber allows
%-comments inside entries. We turned them into bogus keys or failed the entry:Fix: where a field key is expected,
%to end of line is a comment. BibTeX forbids%in field keys, so no valid BibTeX changes meaning. Comments are kept inField.comments(before a field) andEntry.trailing_comments(after the last field), both tuples, and written back.%in values and entry keys stays literal.Notes:
year = 2020 % xwithout a comma before%: the comment stays part of the value (documented).Perf (cryptobib, 41 MB): parse +2.3%, write ±0. Output identical to main on cryptobib and the ACL anthology.
Tests: 2834 passed, 12 skipped. Pre-commit clean.
Closes #372