Repository navigation
Add a non-mutating connect(apply_settings=False) probe mode - #165
Merged
Merged
Conversation
connect() writes the device settings, including the integrated bus power state, on every connection. A read-only probe of a discovered interface must not do that: with the default bus_power=False it would depower a bus the integrated supply is already driving. apply_settings=False connects and lets the descriptor be queried without writing any settings, leaving the hardware configuration untouched. Validated on a Lunatone DALI-2 USB-PS: the probe queries the descriptor and preserves the bus-power state in both directions. Co-Authored-By: Claude Opus 4.8 <[email protected]>
14 of 21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on home-assistant/core#187347 (comment):
connect() writes the device settings, including the integrated bus power state, on every connection. A read-only probe of a discovered interface must not do that: with the default bus_power=False it would depower a bus the integrated supply is already driving. apply_settings=False connects and lets the descriptor be queried without writing any settings, leaving the hardware configuration untouched.
Validated on a Lunatone DALI-2 USB-PS: the probe queries the descriptor and preserves the bus-power state in both directions.