Repository navigation
loader: fix RPi 5 UART initialization prototype - #619
Merged
Merged
Conversation
dreamliner787-9
approved these changes
Oct 26, 2026
dreamliner787-9
left a comment
dreamliner787-9
left a comment
Collaborator
There was a problem hiding this comment.
This is good to merge once you fix the gitlint.
r4v3n6101
force-pushed
the
fix-rpi5-uart
branch
from
October 26, 2026 09:18
21f1aa0 to
ea5a6a6
Compare
Declare `uart_init` with an explicit void parameter list, matching `uart.h`. Fixes Clang's `-Wstrict-prototypes` error when building the BCM2712 loader with `CONFIG_PRINTING` enabled. Signed-off-by: r4v3n6101 <[email protected]>
r4v3n6101
force-pushed
the
fix-rpi5-uart
branch
from
October 26, 2026 09:19
ea5a6a6 to
08c0a9c
Compare
|
Julia is on leave for the next month, so please don't CC her during that time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...continuation of NixOS/nixpkgs#572133 (comment);
Clang complains about
uart_init()with-Wstrict-prototypes, and-Werrormakes the build fail.cc @midnightveil