Repository navigation
feat: show ICMP reply TTL and HTTP connection info in host details - #87
Merged
Merged
Conversation
…tificate Read echo replies through the ipv4/ipv6 PacketConns with the TTL / hop limit control message enabled and store it as ICMPDetails.ReplyTTL (0 when unknown, e.g. on Windows where control messages are unsupported). Add EstimateHops to estimate the return path hop count. Capture the remote address of the final HTTP response's connection via httptrace and a summary of the leaf certificate from resp.TLS.
Keep the last, minimum and maximum reply TTL of each host, and the most recent 20 TTL changes (with a total count) between consecutive successful replies. Changes are detected on the outage tracker's settled, send-ordered result stream, so late replies cannot fake a change; reset clears them.
…st details The host detail panel shows the reply TTL with the estimated return path hop count, the observed range and the recent TTL changes, and for HTTP(S) targets the remote address, TLS version and leaf certificate with its expiry (yellow within 30 days, red within 7 days or expired).
Unexpected status / body failures (and body read errors) now carry the HTTP details with the remote address and TLS info, so a switchover to a peer that answers 503 is visible.
…eplies Track the remote address / TLS info of the latest HTTP(S) response per host, successful or not (newest send time wins, reset clears it), and expose it via GetConnInfo. Compute the reply TTL last/min/max over the history window instead of all time, so one transient TTL does not keep the range forever. Move GetReplyTTL out of GetRTTPercentiles' doc comment.
Also document the recent-window TTL range and that rejected HTTP responses update the shown peer.
… the new TTL Replies alternating between ECMP paths of unequal length flooded the change list. A different TTL now becomes a candidate and is recorded as a change (timed at its first reply) once it is seen on 3 consecutive successful replies; a reply with the confirmed TTL drops the candidate. Failures and unknown TTLs neither advance nor clear it. The recent-history range still shows the alternation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Collect extra per-probe facts that help notice changes during maintenance (path length changes, DNS/LB switchover, certificate replacement) and show them in the host detail panel (
v). Snapshots/compare will follow in a separate PR.ICMP
FlagTTL/FlagHopLimitonly; combining withFlagSrcis rejected on darwin). Unsupported platforms (Windows) fall back silently to TTL unknown.ICMPDetails.ReplyTTLandEstimateHops(return-path estimate from a guessed initial TTL of 64/128/255).Reply TTL: 54 (≈10 hops, est.), the range over recent replies, and TTL changes.HTTP
GotConn) and the leaf TLS certificate (subject CN, issuer, expiry, TLS version), recorded even withskip_verify.Testing
ReplyTTL > 0on the raw socket path (CI cap_net_raw step).