fix: run on Python 3.11, which the ops host has - #66
Merged
Merged
Conversation
Twenty f-strings broke a replacement field across lines, which only Python 3.12 parses; each is joined back onto one line. CI's unit tests and ruff's target move to 3.11 so the next one is caught before a deploy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ops host (angus) runs Debian 12, whose Python is 3.11.2.
install.shbuilds the venv with the system Python on purpose, so withrequires-python = ">=3.12"it stops at its first step.Nothing here needed 3.12 except the syntax of 20 f-strings in the Crowdin scripts, which split a replacement field across lines (
f"... {\n expr}"). Only Python 3.12 parses that; each is joined back onto one line.requires-pythonand ruff'starget-versionmove to 3.11, so ruff now reports that syntax as invalid.deploy/README.mdsays 3.11+.All 730 tests pass on Python 3.11.16 and 3.14.4.