Repository navigation
fix(windows): make GetIpNetEntry2 optional - #186
Merged
Merged
Conversation
4 tasks
Owner
|
Thanks for the fix and the detailed testing! |
ifdario
pushed a commit
to rayfish/net-tools
that referenced
this pull request
Sep 1, 2026
## Description This adds support for wine in this crate, and pins netdev to an earlier version that still works on wine. We want the most recent version on non-windows platforms however, since there are important improvements e.g. on macOS. ## Breaking Changes none ## Notes & open questions The fix is supposed to be temporary, until shellrow/netdev#186 is merged. The added CI uses a nexttest profile for wine. Two tests are known to fail, but iroh's test suite passes fine without those. ## Change checklist - [ ] Self-review. - [ ] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [ ] Tests if relevant. - [ ] All breaking changes documented.
7 tasks done
7 tasks done
jgeluk
pushed a commit
to legra-ai/net-tools
that referenced
this pull request
Oct 18, 2026
## Description - Partially reverts n0-computer#216 so we don't downgrade netdev to 0.45 on windows anymore. This PR was a workaround until shellrow/netdev#186 was merged and released. - The above PR is now merged and released as netdev 0.46.2, so this PR now updates to that version. ## API Changes None. ## Change checklist - [x] Self-review. - [x] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [x] Tests if relevant. - [x] All API changes documented. - [x] This PR was created by a human that thought critically about the proposed change and wrote an as clear and concise description as they could. - [x] This PR isn't slop, and is carefully crafted to do have the intented effect. - [x] `cargo make` passes locally. --------- Co-authored-by: Floris Bruynooghe <[email protected]>
jgeluk
pushed a commit
to legra-ai/net-tools
that referenced
this pull request
Oct 18, 2026
## Description * we no longer need the netdev override for windows now that shellrow/netdev#186 was released * bump other versions to reduce duplicate versions in downstream apps ## API Changes <!-- Optional, any API additions, deprecations or breaking changes, including how to migrate older code. --> ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [x] Self-review. - [x] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [x] Tests if relevant. - [x] All API changes documented. - [x] This PR was created by a human that thought critically about the proposed change and wrote an as clear and concise description as they could. - [x] This PR isn't slop, and is carefully crafted to do have the intented effect. - [x] `cargo make` passes locally. --------- Co-authored-by: Floris Bruynooghe <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had CI fail recently which I traced to a bump to netdev from 0.45 to 0.46.
Ref https://github.com/n0-computer/iroh/actions/runs/32749963007/job/97507327668?pr=4487
Seems like it's a well known issue in the Wine circles and
GetIpNetEntry2is stubbed out making the process fail.Apparently there's work to get it supported in the bleeding edge of Wine/Proton, but this should make it safe for older setup to work too.
I kept the change as minimal as possible.
Here's a quick matrix after testing on our CI instance after this patch
Built from this branch for
x86_64-pc-windows-gnu, run under Wine 11.0 on Linux(
Ubuntu 22.04, freshWINEPREFIX). Baseline =main(v0.46.1), unmodified.examples/default_gatewayexamples/list_interfacescargo test --lib(20 tests)Before:
After:
default_gatewaycompletes with: